fix(fuzz): correct num1/num2 substitution in bitwise Cairo template #2246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey @gap-editor, thanks for finding this bug in our fuzzer! However, this PR only fixes the immediate bug, and does not tackle the root cause. We prefer to solve both problems at the same time. I've created a more detailed issue on this topic: #2254. Feel free to tackle it if you want. Let me know and I'll assign it to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request description:
My PR fixes a small but critical issue in the
program_bitwiseCairo template used by the fuzzer.Previously, some calls (e.g.
bitwise_xor(num1, num2)andbitwise_or(num1, num2)) referenced identifiersnum1andnum2that were never declared inside the generated Cairo program.This caused Cairo compilation errors such as
Unknown identifier 'num1'and could result in false positives during fuzzing runs.The fix ensures that all function calls consistently substitute actual numeric values using
{num1}and{num2}, just like the rest of the template.